Add @throttle_scope function based view decorator#9963
Open
d-ryzhykau wants to merge 1 commit intoencode:mainfrom
Open
Add @throttle_scope function based view decorator#9963d-ryzhykau wants to merge 1 commit intoencode:mainfrom
@throttle_scope function based view decorator#9963d-ryzhykau wants to merge 1 commit intoencode:mainfrom
Conversation
d-ryzhykau
force-pushed
the
throttle_scope-decorator
branch
from
f80dcb4 to
0513735
Compare
|
|
||
| Each of these decorators is equivalent to setting their respective [api policy attributes][api-policy-attributes]. | ||
|
|
||
| All decorators take a single argument. The ones that end with `_class` expect a single class while the ones ending in `_classes` expect a list or tuple of classes. |
Member
There was a problem hiding this comment.
This line doesn't work for this new decorator... Can we rephrase or add another sentence?
Comment on lines
+163
to
+164
| @throttle_classes([OncePerDayScopedThrottle]) | ||
| @throttle_scope(scope) |
Member
There was a problem hiding this comment.
Is @throttle_classes required every time @throttle_scope is used? I don't think so if the scopes are defined in the project settings... Can we add a test to cover that please?
Also make sure we're aligned with CBV in terms of misconfigurations (e.g specifying an unknown scope)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new decorator allows to set throttle scope for function based views. The implementation was suggested in #9942.
The change includes a test for the new decorator and mention of it in the docs.