feat: add Nostr application#3
Open
ethicnology wants to merge 1 commit into
Open
Conversation
Implements the Nostr application from BIP85 v2.1.0:
- `to_nostr` derives `m/83696968'/9000'/{identity}'/{account}'` and
returns the 32-byte key as a NIP19 Bech32 `nsec` string
- `to_nostr_bytes` returns the raw 32-byte key for callers that need it
Bech32 (not Bech32m) per NIP19; the existing `bitcoin::bech32`
re-export is reused so no new dependency is required.
Cross-verified against the bipsea Python reference and the three BIP85
spec test vectors. Tests cover the spec vectors, bytes/nsec consistency,
nsec format (length 63, `nsec1` prefix), hardened-index rejection,
boundary index 0x7FFFFFFF, reserved zero-index derivation, and
distinct-master distinct-output sanity.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3 +/- ##
==========================================
+ Coverage 85.62% 89.17% +3.54%
==========================================
Files 9 10 +1
Lines 167 194 +27
==========================================
+ Hits 143 173 +30
+ Misses 24 21 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bitcoin/bips#2126