Fix Docker build after build script addition#102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build.rsinto the Docker builder dependency-cache layer before the warm-upcargo build.Why
The post-merge
Publish imageworkflow for PR #101 failed because the Docker cache layer runscargo build --releaseafter copying onlyCargo.toml,Cargo.lock, andmigrations. Since PR #101 addedbuild = "build.rs", Cargo expectsbuild.rsduring that warm-up build.Validation
git diff --checkdocker build --target builder -t diffscope-buildrs-hotfix:local .progressed past the previously failing dependency-cache layer; local Colima later OOMed during the final optimized musl link.cargo fmt --check,cargo clippy --all-targets,npm ci,npm run build,npm test, andcargo test(1565 passed).