fix: add close() calls to test functions to prevent background thread leaks#55
Merged
fabien-marty merged 1 commit intomainfrom Mar 6, 2026
Merged
fix: add close() calls to test functions to prevent background thread leaks#55fabien-marty merged 1 commit intomainfrom
fabien-marty merged 1 commit intomainfrom
Conversation
… leaks Add cache.close() and storage.close() at the end of 21 test functions that were creating Cache/Storage instances without cleaning up the background ExpirationThread they start. Closes #49 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cache.close()at the end of 17 test functions intests/test_cache.pythat were leaking backgroundExpirationThreadinstancesstorage.close()at the end of 4 test functions intests/test_storage.pyfor the same reasonTest plan
make lintpassesmake testpasses (36/36 tests)Made with Cursor