fix: validate expiration_thread_max_checks_per_iteration is not negative#56
Merged
fabien-marty merged 1 commit intomainfrom Mar 6, 2026
Merged
fix: validate expiration_thread_max_checks_per_iteration is not negative#56fabien-marty merged 1 commit intomainfrom
fabien-marty merged 1 commit intomainfrom
Conversation
Add a ValueError when expiration_thread_max_checks_per_iteration is negative in Storage.__post_init__(), consistent with the other parameter validations. Add a corresponding test case. Fixes #53 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValueErrorinStorage.__post_init__()whenexpiration_thread_max_checks_per_iterationis negative, consistent with validation of other parameterstest_storage_invalid_parametersverifying the new validationCloses #53
Made with Cursor