Skip to content

docs: fix CONTRIBUTING.md template and typos; add tests for untested modules#29

Open
yurekami wants to merge 1 commit into
facebookresearch:mainfrom
yurekami:fix/docs-and-test-coverage
Open

docs: fix CONTRIBUTING.md template and typos; add tests for untested modules#29
yurekami wants to merge 1 commit into
facebookresearch:mainfrom
yurekami:fix/docs-and-test-coverage

Conversation

@yurekami
Copy link
Copy Markdown

Summary

  • CONTRIBUTING.md: Fill in project name (was boilerplate __________ placeholder)
  • docs/README.md: Fix three issues:
    • Typo: "followoing" → "following"
    • Typo: "Evaluation your" → "Evaluating your"
    • Broken link: https://github.com/SWE-agent/ProgramBench#installation → relative ../README.md#quickstart (wrong org + non-existent anchor)
  • New tests (25 tests, 28 → 53 total):
    • test_cli.py: Smoke tests for --help on all CLI subcommands (eval, info, blob, blob sync)
    • test_eval_extras.py: Tests for count_testcases(), EvaluationResult.summarize(), and _can_reprocess()
    • test_instance_filters.py: Tests for filter_instances() (regex, slicing, shuffle, has_test_branch)

Test plan

  • All 53 tests pass (uv run pytest -v)
  • ruff check and ruff format --check pass
  • No source code changes — only docs and tests

- Fill in project name in CONTRIBUTING.md (was placeholder "__________")
- Fix typos in docs/README.md ("followoing" -> "following",
  "Evaluation your" -> "Evaluating your")
- Fix broken README link pointing to SWE-agent/ProgramBench#installation
  (now relative ../README.md#quickstart)
- Add CLI smoke tests for info, blob, and top-level help
- Add tests for count_testcases, EvaluationResult.summarize,
  _can_reprocess, and filter_instances
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 22, 2026

Hi @yurekami!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 22, 2026
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 22, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant