docs: fix CONTRIBUTING.md template and typos; add tests for untested modules#29
docs: fix CONTRIBUTING.md template and typos; add tests for untested modules#29yurekami wants to merge 1 commit into
Conversation
- Fill in project name in CONTRIBUTING.md (was placeholder "__________")
- Fix typos in docs/README.md ("followoing" -> "following",
"Evaluation your" -> "Evaluating your")
- Fix broken README link pointing to SWE-agent/ProgramBench#installation
(now relative ../README.md#quickstart)
- Add CLI smoke tests for info, blob, and top-level help
- Add tests for count_testcases, EvaluationResult.summarize,
_can_reprocess, and filter_instances
|
Hi @yurekami! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
__________placeholder)https://github.com/SWE-agent/ProgramBench#installation→ relative../README.md#quickstart(wrong org + non-existent anchor)test_cli.py: Smoke tests for--helpon all CLI subcommands (eval,info,blob,blob sync)test_eval_extras.py: Tests forcount_testcases(),EvaluationResult.summarize(), and_can_reprocess()test_instance_filters.py: Tests forfilter_instances()(regex, slicing, shuffle,has_test_branch)Test plan
uv run pytest -v)ruff checkandruff format --checkpass