feat: add Astro landing page home UI#905
Merged
Gaic4o merged 16 commits intofeature-sliced:mainfrom Mar 12, 2026
Merged
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Solant
requested changes
Mar 11, 2026
Contributor
Solant
left a comment
Solant
left a comment
There was a problem hiding this comment.
-
Is there a reason of using
kebab-casenaming for astro components? I thought astro uses the same component naming as any other framework https://docs.astro.build/en/basics/astro-components -
I think you can use
_pageslayer instead of_home, in order to make it consistent with FSD and to separate it from the docusaurus pages (astro has the simialr issue to Next #874 , so having_pageslayer is somewhat consistent across frameworks 🤔 )
…for Astro components - Rename src/pages/_home → src/pages/_pages for FSD layer naming consistency - Rename Astro component files from kebab-case to PascalCase (hero-banner.astro → HeroBanner.astro, etc.) Made-with: Cursor
…onents to PascalCase - Move ThemeProvider.astro from static-image/ to shared/ui/ (was placed there accidentally) - Rename static-image.astro → StaticImage.astro - Rename static-image-download.astro → StaticImageDownload.astro Made-with: Cursor
- Update astro.config.mjs and tsconfig.astro.json for _pages path - Update import paths in content docs (branding, layers, public-api, slices-segments across all locales) Made-with: Cursor
Solant
approved these changes
Mar 12, 2026
illright
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
If you have any feedback or suggestions for each section, I’d appreciate it if you could leave a comment.
Preview