feat: implement read access control for GET /v1/* routes and enhance health endpoint response#49
Merged
Conversation
…health endpoint response - Introduced `require_protected_read_access` to enforce Bearer token authentication for read routes when `FLIGHTDECK_LOCAL_API_TOKEN` is set, aligning with the existing mutation access model. - Updated the `/health` endpoint to include `read_auth` in the response, indicating whether read routes require Bearer authentication. - Enhanced documentation to clarify the new access requirements for read APIs and updated related tests to validate the changes. This update strengthens security by ensuring that read operations are also protected when a local API token is configured, providing a consistent access control model across the API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Changes
Validation
Run the same checks as CI (see
.github/workflows/ci.yml) before opening / updating the PR. Cursor loads.cursor/rules/flightdeck-ci-artifacts.mdcas a short reminder forstatic/+schemas/gates.uv sync --frozen --extra devuv run python -m ruff check src testsuv run python -m pytestuv run python scripts/generate_schemas.pythengit diff --exit-code schemas/(if models/schemas touched)cd web && npm ci && npm run build && cd .. && git diff --exit-code src/flightdeck/server/static/(ifweb/sources, Vite config, orweb/deps / lockfile change the production bundle)cd web && npx playwright install chromium && npm run test:e2e(ifweb/changed)uv run flightdeck-quickstart-verifyuv run flightdeck --helpWith pip / venv only, use
python -m …equivalents fromDEVELOPMENT.md.Schema / Storage Impact
Risk
Review
@flightdeckdev/maintainerson the org repo). On a fork, GitHub may not auto-request; use Reviewers on the PR.AGENTS.md); linked issue or release note intent noted if helpful.Notes