Decoupling Material and Cupertino (with dart fixes)

[justinmc]

This is a single super mega PR attempting to migrate all Material and Cupertino code from flutter/flutter to material_ui and cupertino_ui.

To create this PR I used:

git filter-repo --path packages/flutter/lib/src/material --path packages/flutter/test/material --path examples/api/lib/material --path examples/api/test/material --path packages/flutter/lib/src/cupertino --path packages/flutter/test/cupertino --path examples/api/lib/cupertino --path examples/api/test/cupertino --path packages/flutter/lib/fix_data/fix_material --path packages/flutter/test_fixes/material --path packages/flutter/lib/fix_data/fix_cupertino.yaml --path packages/flutter/test_fixes/cupertino 
cd ../packages
git remote add source-origin ../flutter
git fetch source-origin
git merge source-origin/master --allow-unrelated-histories

I then cherry picked everything I could from the previous PR (#11568).

For both Material and Cupertino, I'm importing:

• The main source code (packages/flutter/lib/src/<material/cupertino>).
• The widget/unit tests (packages/flutter/test/<material/cupertino>).
• The examples (examples/api/lib/<material/cupertino>).
• The example tests (examples/api/test/<material/cupertino>).
• The dart fixes (packages/flutter/lib/fix_data).
• The dart fix tests (packages/flutter/test_fixes).

TODOs

• Do exports for Material and Cupertino.
• Confirm the directory structure (current plan: lib/src/ for now, reorganize after 1.0.0).
• Try installing and using the packages locally.
• Try running the tests locally (works except for tests with cross imports).
• Try running the example tests locally (work after migrating package:flutter_api_samples import).
• Verify examples work.
• Verify that git blame appears the same in both repos on various files. (Yes, but the SHAs are different, as expected.)
• Add auxiliary files for dart fixes and tests.
• Port imports of material/cupertino in places like examples/test to use the new packages.
• Make sure the analyzer is working in the same exact way as it does in flutter/flutter.
• Fix all test cross imports, or decide to merge this without them and fix later. Can these fixes be ported afterwards? The problem of partial commit SHAs shouldn't apply to these new things.

Open questions

• Are we sure about the directory structure?
  • What happens when a user imports material_ui.dart and there are things with the same name in both m3 and m3e?
• Anything else that should be ported along with this? If these commits touch files that are not included in this PR, but that we later port in, the commits will likely have different SHAs.
• Do we like the examples setup? Separate package at material_ui_examples that points to material_ui via the pubspec workspace. Similar to how flutter/flutter's flutter_api_samples works.

How to try using these packages

Add the local packages to your project:

flutter pub add cupertino_ui --path ../../packages/packages/cupertino_ui
flutter pub add material_ui --path ../../packages/packages/material_ui  

Then import the packages instead of the libraries in the SDK:

- import 'package:flutter/material.dart';
- import 'package:flutter/cupertino.dart';
+ import 'package:material_ui/material_ui.dart';
+ import 'package:cupertino_ui/cupertino_ui.dart';

Resources

• Closed PR where i tried to import everything but forgot dart fixes.
  • Decoupling Material and Cupertino #11568
• Closed PR where I tried and failed to import a single widget by individually importing all of its transitive dependencies with git filter-repo commands.
  • Decoupling Material's ProgressIndicator #11526
• Closed PR where I tried to import just colors.dart (no dependencies), but found that it would create different SHAs between it and this mega PR.
  • Decoupling Material's colors.dart #11543
• Close PR where I tried to import all of Material, before realizing that I would create different SHAs between that PR and a future Cupertino PR.
  • Decoupling Material #11549

[justinmc]

@Piinks I've created a new PR to include the dart fixes, which was easy enough. I spent some time cleaning up the dart fixes so they use the new imports. As of right now all the tests pass:

cd packages/material_ui/test_fixes # Or packages/cupertino_ui/test_fixes
dart fix --compare-to-golden

However I did remove some fixes that seemed to be related exclusively to the Widgets library. Those are still covered in flutter/flutter.

[gemini-code-assist]

Code Review

This pull request transitions the Cupertino library into a standalone package, incorporating source code for core widgets, a comprehensive set of API examples, and a robust suite of tests. It also adds dart fix metadata to assist with future migrations. Feedback identifies critical issues in dialog.dart where undefined classes and properties are used, along with pervasive syntax errors in the example files regarding enum member references. Additionally, several components are missing definitions, and the SDK constraint in the examples' pubspec.yaml must be updated to support the features used in the code.

[gemini-code-assist]

ImageFilterConfig is not a standard Flutter or Dart class, and it is not defined in this package. It appears to be a typo for ImageFilter. Additionally, BackdropFilter does not have a filterConfig property; it should be filter.

  ImageFilter? _buildFilter(Brightness? brightness) {

[gemini-code-assist]

The BackdropFilter widget uses the filter property, not filterConfig.

        child: BackdropFilter(filter: filter, child: contents),

[gemini-code-assist]

The syntax .light is invalid in Dart for referring to an enum member in this context. It should be Brightness.light. This issue is pervasive throughout the example files (e.g., .center, .spaceEvenly, .all, .only, .symmetric, .date, .time, .w600).

Suggested change

	theme: CupertinoThemeData(brightness: .light),
	theme: const CupertinoThemeData(brightness: Brightness.light),

[gemini-code-assist]

ExpansibleController and Expansible are used but not defined in this file, nor are they imported from any of the dependencies. If these are intended to be part of the package, they should be included in the source code.

[gemini-code-assist]

RadioGroup is not a standard Flutter widget and is not defined in the provided patches. If it is a custom widget intended for this package, ensure its definition is included.

[gemini-code-assist]

The SDK constraint is too low for the features used in this package, such as withValues, ColorSpace, and ClipRSuperellipse. It should be updated to at least ^3.22.0 or higher.

  sdk: ^3.22.0

[gemini-code-assist]

This import is redundant as FlutterLogo is available via package:cupertino_ui/cupertino_ui.dart (which exports widgets.dart).