Decoupling Material and Cupertino (with dart fixes)#11669
Open
justinmc wants to merge 7860 commits into
Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a single super mega PR attempting to migrate all Material and Cupertino code from flutter/flutter to material_ui and cupertino_ui.
To create this PR I used:
I then cherry picked everything I could from the previous PR (#11568).
For both Material and Cupertino, I'm importing:
TODOs
package:flutter_api_samplesimport).git blameappears the same in both repos on various files. (Yes, but the SHAs are different, as expected.)FixSkip all test cross imports.Open questions
workspace. Similar to how flutter/flutter's flutter_api_samples works.How to try using these packages
Add the local packages to your project:
Then import the packages instead of the libraries in the SDK:
How to review this PR
flutter/material.darttomaterial_ui/material_ui.dartand the equivalent for Cupertino.And let me know if there is any code that's not in this PR that you expected to be. It will be best to get everything we can in this one PR rather than following up later in order to prevent fragmenting commits.
Resources
git filter-repocommands.