Open
Conversation
jorgemmsilva
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse,
onbjerg,
stevencartavia and
zerosnacks
as code owners
mablr
reviewed
Apr 24, 2026
Collaborator
mablr
left a comment
mablr
left a comment
There was a problem hiding this comment.
Makes sense as it’s a pattern we also have in alloy and foundry-core. @zerosnacks wdyt?
Btw some wiring is certainly missing.
| gcp-kms = ["foundry-wallets/gcp-kms"] | ||
| turnkey = ["foundry-wallets/turnkey"] | ||
| isolate-by-default = ["foundry-config/isolate-by-default"] | ||
| native-tls = ["foundry-cli/native-tls"] |
Collaborator
There was a problem hiding this comment.
Logically, "foundry-block-explorers/openssl" should also be included here?
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a
native-tlsbuild flag. This is helpful for people that must use cast behind corporate proxies.tried this solution, but it didn't work for me:
#4792