Skip to content

fix(config): disable proxy detection in Etherscan client #14454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AissataF wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −0
Open

fix(config): disable proxy detection in Etherscan client #14454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/config/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ mesc.workspace = true
unit-prefix = "0.5.2"
rayon.workspace = true
regex.workspace = true
reqwest = { version = "0.12", default-features = false }
Copy link
Copy Markdown
Collaborator

@mablr mablr Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foundry_block_explorerswas bumped here 1ea7425 and now depends on 0.13

Copy link
Copy Markdown
Author

@AissataF AissataF Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait for foundry-rs/foundry-core#51 and fix them together.

semver = { workspace = true, features = ["serde"] }
serde_json.workspace = true
serde.workspace = true
Expand Down
6 changes: 6 additions & 0 deletions crates/config/src/etherscan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,13 @@ impl ResolvedEtherscanConfig {
}
}

// Disable automatic proxy detection. In sandboxed environments (e.g., Cursor IDE,
// macOS App Sandbox), reqwest's system proxy lookup via SCDynamicStore can crash
// when the API returns NULL. See: https://github.com/foundry-rs/foundry/issues/12733
let http_client = reqwest::Client::builder().no_proxy().build()?;

let mut client_builder = foundry_block_explorers::Client::builder()
.with_client(http_client)
.with_api_key(api_key)
.with_cache(cache, Duration::from_secs(24 * 60 * 60));
if let Some(ref browser_url) = browser_url {
Expand Down
Loading