Open
Conversation
stevencartavia
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse,
onbjerg and
zerosnacks
as code owners
mablr
reviewed
Apr 27, 2026
| let n = name.name; | ||
| if n == kw::Call | ||
| || n == kw::Delegatecall | ||
| || n == kw::Staticcall |
Collaborator
There was a problem hiding this comment.
Staticcall is read-only, unsure it makes sense to flag it.
Comment on lines
+274
to
+279
| if self.guard_depth > 0 { | ||
| self.guarded.extend(srcs.iter().copied()); | ||
| } | ||
| if self.sink_depth > 0 { | ||
| self.sinks.extend(srcs.iter().copied()); | ||
| } |
Collaborator
There was a problem hiding this comment.
Guard ordering is not enforced.
This seems to be a false negative:
function guardAfterSink(address a) external {
owner = a; // sink: 'a' written to state
require(a != address(0)); // guard too late, but marks 'a' as guarded anyway
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
missing-zero-checklint that flags address parameters of externally-callable functions and constructors used in state writes or value transfers(call/delegatecall/staticcall/transfer/send)without a priorrequire/assert/ifcheck.Testing
cargo run -p forge -- lint crates/lint/testdata/MissingZeroCheck.sol