fix(anvil): honor max on-disk state limit as inclusive cap#14463
Open
cuiweixie wants to merge 1 commit intofoundry-rs:masterfrom
Open
fix(anvil): honor max on-disk state limit as inclusive cap#14463cuiweixie wants to merge 1 commit intofoundry-rs:masterfrom
cuiweixie wants to merge 1 commit intofoundry-rs:masterfrom
Conversation
enforce_limits evicted while oldest_on_disk.len() >= max_on_disk_limit,\nso the queue never reached the configured maximum (effective cap was\nN-1). Only purge when the count is strictly greater than the limit.
cuiweixie
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse,
onbjerg,
stevencartavia and
zerosnacks
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InMemoryBlockStates::enforce_limitsdocumentsmax_on_disk_limitas the maximum number of states kept on disk. The on-disk eviction loop usedoldest_on_disk.len() >= max_on_disk_limit, which removed an entry as soon as the count reached the limit, so the cache could hold at most N−1 entries.Evict only when the length is strictly greater than the limit so up to N states may remain, matching the documented semantics.
Test plan
cargo check -p anvil