Draft
Conversation
Resolve version channels via the GitHub API instead of relying on
mutable Git tags:
- 'latest' (default) and 'stable' (alias): use /releases/latest
endpoint to find the latest non-prerelease release
- 'nightly': search releases listing for the latest nightly-{SHA}
prerelease
- Specific versions (v1.2.3, nightly-{SHA}) still work directly
Also:
- Add download_json() to Downloader for GitHub API calls
- Add reqwest 'json' feature
- Update help text and tests
Amp-Thread-ID: https://ampcode.com/threads/T-019dbf9e-5115-77b9-a177-1af9d30af00c
Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019dbf9e-5115-77b9-a177-1af9d30af00c Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019dbf9e-5115-77b9-a177-1af9d30af00c Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion PR to foundry-rs/foundry#14445. Resolves version channels via the GitHub API instead of relying on mutable Git tags (
nightly,stable).Changes
latestis now the default channel (wasstable)stableis a silent alias forlatestlatest/stableuse the/releases/latestGitHub API endpoint — single API call, always finds the correct release regardless of how many nightlies existnightlysearches the releases listing (per_page=10) for the latestnightly-{SHA}prereleasev1.2.3,nightly-{SHA}) still work directly without API callsdownload_json()toDownloaderfor GitHub API callsjsonfeatureinstall_nightly_specifictest for pinned nightly installsUser-facing behavior
foundryup/releases/latest)foundryup -i latestfoundryup -i stablelatestfoundryup -i nightlyfoundryup -i nightly-abc123...foundryup -i v1.6.0Companion PR