Skip to content

Check PG::BinaryEncoder::CopyRow array input size #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
larskanis wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −0
Open

Check PG::BinaryEncoder::CopyRow array input size #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ext/pg_copy_coder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,10 @@ pg_bin_enc_copy_row(t_pg_coder *conv, VALUE value, char *out, VALUE *intermediat
char *current_out;
char *end_capa_ptr;

if( RARRAY_LEN(value) >= 32768 ){
rb_raise( rb_eArgError, "too many columns in array for PG::BinaryEncoder::CopyRow: %ld", RARRAY_LEN(value) );
}

p_typemap = RTYPEDDATA_DATA( this->typemap );
p_typemap->funcs.fit_to_query( this->typemap, value );

Expand Down
4 changes: 4 additions & 0 deletions spec/pg/type_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1434,6 +1434,10 @@ def expect_deprecated_coder_init
to eq("\x00\x02\x00\x00\x00\x01x\x00\x00\x00\x02yz")
end

it "should'nt encode too big array" do
expect{ encoder.encode(["x"]*32768) }.to raise_error(ArgumentError, /too many columns/)
end

it 'should output a string with correct character encoding' do
v = encoder.encode(["Héllo"], "iso-8859-1")
expect( v.encoding ).to eq( Encoding::ISO_8859_1 )
Expand Down
Loading