Skip to content

Raise on a too large input string to PG::TextEncoder::Bytea #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
larskanis wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −1
Open

Raise on a too large input string to PG::TextEncoder::Bytea #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ext/pg_text_encoder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,9 +430,14 @@ pg_text_enc_bytea(t_pg_coder *conv, VALUE value, char *out, VALUE *intermediate,
}
return (int)(optr - out);
}else{
long size;
*intermediate = rb_obj_as_string(value);
size = RSTRING_LEN(*intermediate);

/* The output starts with "\x" and each character is converted to hex. */
return 2 + RSTRING_LENINT(*intermediate) * 2;
if( size > INT_MAX / 2 - 2 )
rb_raise( rb_eArgError, "too large input string for PG::TextEncoder::Bytea: %ld", size );
return 2 + size * 2;
}
}

Expand Down
9 changes: 9 additions & 0 deletions spec/pg/type_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,15 @@ def textdec_timestamptz_decode_should_fail(str)
expect( textenc_bytea.encode("\x00\x01\x02\x03\xef".b) ).to eq( "\\x00010203ef" )
end

it "should raise too large string to bytea" do
n = 1_073_741_822
data = "A".b * n
enc = PG::TextEncoder::ToBase64.new(
elements_type: PG::TextEncoder::Bytea.new
)
expect{ enc.encode(data) }.to raise_error(ArgumentError, /too large input string/)
end

context 'text timestamps' do
it 'encodes timestamps without timezone' do
expect( textenc_timestamp.encode(Time.new(2016,1,2, 23, 23, 59.123456, 3*60*60)) ).
Expand Down
Loading