fix(React): assign CustomDataView to SharedService, fixes #2614

[ghiscoding]

fixes #2614 which is related to an MSSQL issue using a Custom DataView in 1 of their grids.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (f4e7533) to head (71714ae).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2617   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         200      200           
  Lines       25285    25285           
  Branches     8945     8945           
=======================================
  Hits        25283    25283           
  Misses          2        2           

Flag	Coverage Δ
angular	100.0% <ø> (ø)
universal	100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pkg-pr-new]

angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2617

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2617

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2617

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2617

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2617

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2617

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2617

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2617

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2617

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2617

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2617

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2617

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2617

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2617

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2617

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2617

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2617

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2617

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2617

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2617

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2617

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2617

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2617

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2617

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2617

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2617

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2617

@slickgrid-universal/web-mcp

npm i https://pkg.pr.new/@slickgrid-universal/web-mcp@2617

commit: 71714ae

[aasimkhan30]

The changes look good overall. Thanks for the quick turnaround!

One small NIT:

The new CustomDataView interface makes getItems and setItems required, but our windowed view has no setItems (it's driven by setRows/setLength), and the library never calls setItems for a custom data view anyway since that call site is gated behind !props.customDataView. Could those two stay optional (?)? That matches the original interface shape and avoids forcing a no-op setItems on consumers.

[ghiscoding]

@aasimkhan30 hmm ok I changed it, it required more optional chaining checks in Slickgrid-React for this though... I just thought these 2 functions were the minimum but I guess I was wrong since in the end I've never actually used any Custom DataView myself and I always relied on the SlickDataView.

So can you give a try to pkg.pr.new nonetheless, it should help confirming if it really works before releasing a new patch version

[aasimkhan30]

@ghiscoding , gave it a quick try and everything works. Thanks for making this fix!