Skip to content

fix(launch): use a clear cancel label in the shortlink confirmation dialog #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giladresisi wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −1
Open

fix(launch): use a clear cancel label in the shortlink confirmation dialog #1677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/frontend/src/components/new-launch/manage.modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,9 @@ export const ManageModal: FC<AddEditModalProps> = (props) => {
'shortlink_urls_question',
'Do you want to shortlink the URLs? it will let you get statistics over clicks'
),
t('yes_shortlink_it', 'Yes, shortlink it!')
t('yes_shortlink_it', 'Yes, shortlink it!'),
undefined,
t('no_original_urls', 'No, original URLs')
Comment on lines +378 to +380

@sentry sentry Bot Jul 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The translation key no_original_urls is missing for the Georgian (ka_ge) locale, causing an English fallback string to be displayed on a button for Georgian users.
Severity: LOW

Suggested Fix

Add the missing no_original_urls key with its corresponding Georgian translation to the libraries/react-shared-libraries/src/translation/locales/ka_ge/translation.json file to ensure consistent localization.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: apps/frontend/src/components/new-launch/manage.modal.tsx#L378-L380

Potential issue: The translation key `no_original_urls` is missing from the Georgian
locale file (`ka_ge/translation.json`). The code at the specified location calls
`i18next.t('no_original_urls', 'No, original URLs')`, providing a hardcoded English
string as a fallback. For users with their language set to Georgian, the system fails to
find the translation key and defaults to this English text. This results in a
mixed-language user experience within the shortlink confirmation dialog, where the
cancel button appears in English while the rest of the UI is in Georgian.

Did we get this right? 👍 / 👎 to inform future reviews.

);
}
}
Expand Down
1 change: 1 addition & 0 deletions i18n.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,7 @@ checksums:
please_fix_your_settings: 41c970bc73bb775e8b1882dfdbaad569
shortlink_urls_question: 5308003901830e666ff9915b4855a9c9
yes_shortlink_it: b784b6f9ce6d5eec451de7f3c7f1e01d
no_original_urls: 06cf15a6bf380da85f537f425dd6d236
added_successfully: 5a1557f26138d3f80b6449d4570d47a9
updated_successfully: fb4e4de59015fd30331e0f56c63918c5
create_post_title: 06549e1cb8bbba2645f5ded68259684d
Expand Down
1 change: 1 addition & 0 deletions libraries/react-shared-libraries/src/translation/locales/ar/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@
"please_fix_your_settings": "يرجى تصحيح إعداداتك",
"shortlink_urls_question": "هل تريد تقصير الروابط؟ سيسمح لك ذلك بالحصول على إحصائيات حول النقرات",
"yes_shortlink_it": "نعم، قصّر الرابط!",
"no_original_urls": "لا، أبقِ الروابط الأصلية!",
"added_successfully": "تمت الإضافة بنجاح",
"updated_successfully": "تم التحديث بنجاح",
"create_post_title": "إنشاء منشور",
Expand Down
1 change: 1 addition & 0 deletions libraries/react-shared-libraries/src/translation/locales/bn/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@
"please_fix_your_settings": "অনুগ্রহ করে আপনার সেটিংস ঠিক করুন",
"shortlink_urls_question": "আপনি কি URL গুলো শর্টলিংক করতে চান? এতে আপনি ক্লিকের পরিসংখ্যান পেতে পারবেন",
"yes_shortlink_it": "হ্যাঁ, শর্টলিংক করুন!",
"no_original_urls": "না, মূল URL রাখুন",
"added_successfully": "সফলভাবে যোগ হয়েছে",
"updated_successfully": "সফলভাবে আপডেট হয়েছে",
"create_post_title": "পোস্ট তৈরি করুন",
Expand Down
1 change: 1 addition & 0 deletions libraries/react-shared-libraries/src/translation/locales/de/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@
"please_fix_your_settings": "Bitte korrigieren Sie Ihre Einstellungen",
"shortlink_urls_question": "Möchten Sie die URLs kürzen? So erhalten Sie Statistiken über Klicks.",
"yes_shortlink_it": "Ja, bitte kürzen!",
"no_original_urls": "Nein, Original-URLs",
"added_successfully": "Erfolgreich hinzugefügt",
"updated_successfully": "Erfolgreich aktualisiert",
"create_post_title": "Beitrag erstellen",
Expand Down
1 change: 1 addition & 0 deletions libraries/react-shared-libraries/src/translation/locales/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,6 +651,7 @@
"please_fix_your_settings": "Please fix your settings",
"shortlink_urls_question": "Do you want to shortlink the URLs? it will let you get statistics over clicks",
"yes_shortlink_it": "Yes, shortlink it!",
"no_original_urls": "No, original URLs",
"added_successfully": "Added successfully",
"updated_successfully": "Updated successfully",
"create_post_title": "Create Post",
Expand Down
1 change: 1 addition & 0 deletions libraries/react-shared-libraries/src/translation/locales/es/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@
"please_fix_your_settings": "Por favor, corrige tu configuración",
"shortlink_urls_question": "¿Quieres acortar las URLs? Esto te permitirá obtener estadísticas sobre los clics",
"yes_shortlink_it": "¡Sí, acórtala!",
"no_original_urls": "No, URLs originales",
"added_successfully": "Agregado exitosamente",
"updated_successfully": "Actualizado exitosamente",
"create_post_title": "Crear publicación",
Expand Down
1 change: 1 addition & 0 deletions libraries/react-shared-libraries/src/translation/locales/fr/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@
"please_fix_your_settings": "Veuillez corriger vos paramètres",
"shortlink_urls_question": "Voulez-vous raccourcir les URL ? Cela vous permettra d'obtenir des statistiques sur les clics.",
"yes_shortlink_it": "Oui, raccourcissez-les !",
"no_original_urls": "Non, URLs originales",
"added_successfully": "Ajouté avec succès",
"updated_successfully": "Mis à jour avec succès",
"create_post_title": "Créer une publication",
Expand Down
1 change: 1 addition & 0 deletions libraries/react-shared-libraries/src/translation/locales/he/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@
"please_fix_your_settings": "אנא תקן את ההגדרות שלך",
"shortlink_urls_question": "האם ברצונך לקצר את הקישורים? זה יאפשר לך לקבל סטטיסטיקות על הקלקות",
"yes_shortlink_it": "כן, קצר את זה!",
"no_original_urls": "לא, כתובות URL מקוריות",
"added_successfully": "נוסף בהצלחה",
"updated_successfully": "עודכן בהצלחה",
"create_post_title": "צור פוסט",
Expand Down
1 change: 1 addition & 0 deletions libraries/react-shared-libraries/src/translation/locales/it/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@
"please_fix_your_settings": "Per favore, correggi le tue impostazioni",
"shortlink_urls_question": "Vuoi accorciare gli URL? Ti permetterà di ottenere statistiche sui clic",
"yes_shortlink_it": "Sì, accorcialo!",
"no_original_urls": "No, URL originali",
"added_successfully": "Aggiunto con successo",
"updated_successfully": "Aggiornato con successo",
"create_post_title": "Crea post",
Expand Down
1 change: 1 addition & 0 deletions libraries/react-shared-libraries/src/translation/locales/ja/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@
"please_fix_your_settings": "設定を修正してください",
"shortlink_urls_question": "URLを短縮リンクにしますか？クリック数の統計を取得できます。",
"yes_shortlink_it": "はい、短縮リンクにします！",
"no_original_urls": "いいえ、元のURLのままにします",
"added_successfully": "追加に成功しました",
"updated_successfully": "更新に成功しました",
"create_post_title": "投稿を作成",
Expand Down
1 change: 1 addition & 0 deletions libraries/react-shared-libraries/src/translation/locales/ko/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@
"please_fix_your_settings": "설정을 수정해 주세요",
"shortlink_urls_question": "URL을 단축하시겠습니까? 클릭 통계를 확인할 수 있습니다.",
"yes_shortlink_it": "네, 단축하세요!",
"no_original_urls": "아니요, 원래 URL을 유지하세요!",
"added_successfully": "성공적으로 추가되었습니다",
"updated_successfully": "성공적으로 업데이트되었습니다",
"create_post_title": "게시물 작성",
Expand Down
1 change: 1 addition & 0 deletions libraries/react-shared-libraries/src/translation/locales/pt/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@
"please_fix_your_settings": "Por favor, corrija suas configurações",
"shortlink_urls_question": "Você quer encurtar as URLs? Isso permitirá obter estatísticas sobre os cliques",
"yes_shortlink_it": "Sim, encurte!",
"no_original_urls": "Não, URLs originais",
"added_successfully": "Adicionado com sucesso",
"updated_successfully": "Atualizado com sucesso",
"create_post_title": "Criar publicação",
Expand Down
1 change: 1 addition & 0 deletions libraries/react-shared-libraries/src/translation/locales/ru/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@
"please_fix_your_settings": "Пожалуйста, исправьте ваши настройки",
"shortlink_urls_question": "Хотите сократить ссылки? Это позволит получать статистику по кликам.",
"yes_shortlink_it": "Да, сократить!",
"no_original_urls": "Нет, оставить оригинальные URL",
"added_successfully": "Успешно добавлено",
"updated_successfully": "Успешно обновлено",
"create_post_title": "Создать пост",
Expand Down
1 change: 1 addition & 0 deletions libraries/react-shared-libraries/src/translation/locales/tr/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@
"please_fix_your_settings": "Lütfen ayarlarınızı düzeltin",
"shortlink_urls_question": "URL'leri kısaltmak ister misiniz? Bu, tıklamalar üzerinde istatistik almanızı sağlar.",
"yes_shortlink_it": "Evet, kısalt!",
"no_original_urls": "Hayır, orijinal URL'leri koru!",
"added_successfully": "Başarıyla eklendi",
"updated_successfully": "Başarıyla güncellendi",
"create_post_title": "Gönderi Oluştur",
Expand Down
1 change: 1 addition & 0 deletions libraries/react-shared-libraries/src/translation/locales/vi/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@
"please_fix_your_settings": "Vui lòng sửa cài đặt của bạn",
"shortlink_urls_question": "Bạn có muốn rút gọn các URL không? Điều này sẽ giúp bạn thống kê số lần nhấp chuột",
"yes_shortlink_it": "Vâng, hãy rút gọn!",
"no_original_urls": "Không, giữ URL gốc!",
"added_successfully": "Thêm thành công",
"updated_successfully": "Cập nhật thành công",
"create_post_title": "Tạo bài đăng",
Expand Down
1 change: 1 addition & 0 deletions libraries/react-shared-libraries/src/translation/locales/zh/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@
"please_fix_your_settings": "请修正您的设置",
"shortlink_urls_question": "您想要对网址进行短链处理吗？这样可以统计点击次数。",
"yes_shortlink_it": "是的，短链处理！",
"no_original_urls": "不，保留原始网址！",
"added_successfully": "添加成功",
"updated_successfully": "更新成功",
"create_post_title": "创建帖子",
Expand Down
Loading