Skip to content

Removed onlyIf since it may produce wrong results when removing all…#328

Merged
gmazzo merged 1 commit intomainfrom
no-onlyif
Nov 16, 2025
Merged

Removed onlyIf since it may produce wrong results when removing all…#328
gmazzo merged 1 commit intomainfrom
no-onlyif

Conversation

@gmazzo
Copy link
Copy Markdown
Owner

@gmazzo gmazzo commented Nov 16, 2025

… constants

@gmazzo gmazzo enabled auto-merge (squash) November 16, 2025 02:43
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.05%. Comparing base (8eb37d8) to head (2f2dbf0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   66.20%   66.05%   -0.16%     
==========================================
  Files          23       23              
  Lines         870      866       -4     
  Branches      204      203       -1     
==========================================
- Hits          576      572       -4     
- Misses        214      215       +1     
+ Partials       80       79       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmazzo gmazzo merged commit a9796c6 into main Nov 16, 2025
25 checks passed
@gmazzo gmazzo deleted the no-onlyif branch November 16, 2025 02:56
gmazzo added a commit that referenced this pull request Nov 21, 2025
@gmazzo
Revert "Removed onlyIf since it may produce wrong results when remo…
b97c79f 
…ving all constants (#328)"

This reverts commit a9796c6.
@gmazzo gmazzo mentioned this pull request Nov 21, 2025
Merged
gmazzo added a commit that referenced this pull request Nov 21, 2025
@gmazzo
Restores onlyIf because cases configuration issues (#339)
bb55bb5 
* Revert "Removed `onlyIf` since it may produce wrong results when removing all constants (#328)"

This reverts commit a9796c6.

* Reverts `onlyIf` removal, tries to keep accurate output
gmazzo added a commit that referenced this pull request Nov 21, 2025
@gmazzo
Removed ios targets from KMP tests (#340)
16e16a0 
* Revert "Removed `onlyIf` since it may produce wrong results when removing all constants (#328)"

This reverts commit a9796c6.

* Removed `ios` targets from KMP tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gmazzo