This repository was archived by the owner on Oct 14, 2025. It is now read-only.
change profiling based partitoner's last_segment_latency to slowest_segment_latency#24
Open
HanChangHun wants to merge 1 commit intogoogle-coral:masterfrom
Open
change profiling based partitoner's last_segment_latency to slowest_segment_latency#24HanChangHun wants to merge 1 commit intogoogle-coral:masterfrom
HanChangHun wants to merge 1 commit intogoogle-coral:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
to slowest_segment_latency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed profile-based partitioner's
last_segment_latencytoslowest_segment_latency.Actually it does not guarantee gap between slowest_segment_latency and fastest_segment_latency lower than
diff_threshold_ns. But when using this code, I can see that the difference was reduced.I tried to use a different method, but I didn't converge.
And I tested by utilizing only one TPU. So I couldn't proceed with the experiment on more than 2 TPUs.
I'm using M.2 Accelerator with Dual Edge TPU, but I can't catch two TPUs... So my test can be inaccurate.