chore(deps): bump soupsieve from 2.8.3 to 2.8.4 in /python/agents/personalized-shopping#2199
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [soupsieve](https://github.com/facelessuser/soupsieve) from 2.8.3 to 2.8.4. - [Release notes](https://github.com/facelessuser/soupsieve/releases) - [Commits](facelessuser/soupsieve@2.8.3...2.8.4) --- updated-dependencies: - dependency-name: soupsieve dependency-version: 2.8.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Correctness review findings for python/agents/financial-advisor/financial_advisor/__init__.py:
- Calling
google.auth.default()unconditionally at import-time will crash with aDefaultCredentialsErrorin environments where Google Cloud credentials are not configured. Consider wrapping this in atry...exceptblock to allow importing the package gracefully. - If
google.auth.default()returnsNonefor the project ID, callingos.environ.setdefault("GOOGLE_CLOUD_PROJECT", project_id)will attempt to setNoneas the environment variable value, raisingTypeError: str expected, not NoneType. Consider verifyingproject_idis notNonebefore setting it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps soupsieve from 2.8.3 to 2.8.4.
Release notes
Sourced from soupsieve's releases.
Commits
28108abLimit excessive selectorsef18872Fix test for Windowseb43976Merge commit from fork3a661b2Fix typo in pseudo-classes.md (#294)0cb533dUpdate hatchling version requirement in pyproject.toml (#290)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.