remove global name validation#892
Conversation
juliusmh
force-pushed
the
remove_global_name_validation
branch
3 times, most recently
from
f9c5913 to
e0e77cf
Compare
juliusmh
force-pushed
the
remove_global_name_validation
branch
from
e0e77cf to
8092852
Compare
There was a problem hiding this comment.
Instead of pkg/util/validation.IsValidLabelName and pkg/util/validation.IsValidMetricName, I think a more forward looking solution would be to implement a method pkg/util/validation.Overrides.NameValidationScheme(tenantID string) validation.NamingScheme, and use that wherever you need to validate metric or label names. It can hard-code the legacy scheme, so we don't make it configurable at first. If we have such a solution, we can easily implement the next step, which is per-tenant configurability of metric/label name validation scheme.
juliusmh
force-pushed
the
remove_global_name_validation
branch
3 times, most recently
from
31aff3b to
2ceae43
Compare
juliusmh
force-pushed
the
remove_global_name_validation
branch
3 times, most recently
from
af1fe5f to
0f47658
Compare
aknuds1
left a comment
aknuds1
left a comment
There was a problem hiding this comment.
It doesn't seem right to me to essentially duplicate prometheus/common/model.ValidationScheme via model/validation.NamingScheme. It's going to be bad to maintain, and a potential footgun. Please see my alternative suggestion :)
juliusmh
force-pushed
the
remove_global_name_validation
branch
from
0f47658 to
ef1d8b1
Compare
…ng and query evaluation
…t, textparse, labels.
juliusmh
force-pushed
the
remove_global_name_validation
branch
from
ef1d8b1 to
c0349fd
Compare
|
Superseded by #946 |
3 participants
This PR introduces explicit APIs to set validation scheme for various components of prometheus.
Uses / Depends on: