refactor(validation): move per-type validation into series plugins#641
Merged
Conversation
Remove the per-type switch from validateData and delegate type-specific checks to an optional validate() on each series plugin (CHARTS-12940). - Add validate?(args) + ValidateSeriesArgs to the SeriesPlugin interface - Add hasSeriesPlugin/getRegisteredSeriesTypes so the registry is the source of truth for available types (drops the SERIES_TYPE hardcode) - Extract shared XY helpers into core/validation/helpers.ts - Add validate() to area, bar-x, bar-y, line, scatter, pie, treemap; pie/treemap checks live in their own plugins - Register plugins in the validation test so getSeriesPlugin resolves Error codes and messages are preserved.
|
📖 Docs Preview is ready. |
Contributor
|
Preview is ready. |
|
Visual Tests Report is ready. |
kuzmadom
reviewed
Jun 22, 2026
Drop the concrete-series union (XYSeries) and per-type params from the shared validation helpers; type them by the shape they actually read so core no longer enumerates specific series types.
kuzmadom
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
validateDatahad a switch over the series type, so adding a new type meantediting a central file. Type-specific validation now lives in the type's own
plugin, keeping the change local. Part of the ongoing pluginization effort.
What changed
SeriesPlugin: optionalvalidate?(args)method +ValidateSeriesArgstype.Core loops over series and delegates via
getSeriesPlugin(type).validate?.(...).hasSeriesPlugin/getRegisteredSeriesTypesreplace the hardcodedSERIES_TYPElist in validation.core/validation/helpers.ts.validate()added to area, bar-x, bar-y, line, scatter, pie, treemap.Single-consumer logic (pie value check, treemap structure check) lives in its
own plugin rather than in shared helpers.
validateSeries/countSeriesByType/validateStackingAreaNullMode.import '../../../plugins') so theregistry is populated.
Behavior
Unchanged — same error codes and messages. The only difference is that the type
list in the
invalid-series-typemessage now follows plugin registration order.