Skip to content

Race condition when setting delegate form react-native wrapper #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nazgu1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Race condition when setting delegate form react-native wrapper #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Sources/Grovs/Grovs.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,12 @@ public protocol GrovsDelegate {

/// A class representing Grovs SDK.
public class Grovs {
private static var _delegate: GrovsDelegate?

/// The delegate to receive callbacks from the SDK.
public static var delegate: GrovsDelegate? {
set {
_delegate = newValue
manager?.delegate = newValue
}

Expand All @@ -30,7 +32,11 @@ public class Grovs {
private static var APIKey: String!

/// The manager handling Grovs functionality.
private static var manager: GrovsManager?
private static var manager: GrovsManager? {
didSet {
manager?.delegate = _delegate
}
}

// MARK: Public methods

Expand Down