-
Notifications
You must be signed in to change notification settings - Fork 4k
servlet: fix write when not ready in AsyncServletOutputStreamWriter #12790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mgustimz
wants to merge
11
commits into
grpc:master
Choose a base branch
from
mgustimz:fix/12723-servlet-clean
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+194
−5
Open
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3f87103
servlet: fix write when not ready in AsyncServletOutputStreamWriter
mgustimz 60e9f16
servlet: fix write when not ready, narrow to writeBytes only
mgustimz 44ee627
servlet: fix type comparison in runOrBuffer
mgustimz 55e6629
Add AsyncServletOutputStreamWriterTest with mock isReady supplier
mgustimz 3ebac15
Remove unused AtomicInteger in AsyncServletOutputStreamWriterTest
mgustimz 1ef9eb8
Fix test and log message per Copilot review
mgustimz 3f81019
Split flush and writeBytes into separate branches
mgustimz d79bdb6
Clean up test per Copilot review
mgustimz c73e67a
Add test validating write without onWritePossible is buffered
mgustimz e898755
Address Copilot review items from #4251754607
mgustimz 8c217f5
Replace third test to cover flush-specific behavior
mgustimz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.