Invert bulge value calculation in import_dxf.py#1372
Open
greyltc wants to merge 1 commit into
Open
Conversation
Invert the bulge value for the start point in the import_dxf function.
There was a problem hiding this comment.
Pull request overview
This PR adjusts DXF polyline bulge handling so imported bulged segments (arcs) curve in the expected direction, addressing the “inverted arcs” behavior reported in #1368.
Changes:
- Invert the per-segment bulge sign used when converting DXF polylines into
SagittaArcedges.
Comments suppressed due to low confidence (1)
src/build123d/import_dxf.py:216
math.dist(start_point, end_point)is computed twice per segment (degeneracy check and sagitta calculation). Cache the chord length once to avoid redundant sqrt work and keep the loop easier to read; you can also simplify the sign inversion to-start_data[2].
bulge = -1 * start_data[2] if len(start_data) > 2 else 0
if math.dist(start_point, end_point) < TOLERANCE:
continue
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invert the bulge value for the start point in the import_dxf function. Fixes #1368