Wikipedia url#56
Conversation
…ikipedia_urls. There is still a function to add urls and there is now one to remove them as well. Add url doesnt need a prefix, it will auto put one, but a custom one may be included and defualt will not be added (if wanted forever whatever reason). The remove function acccepts a inputs with prefix+url or just url.
|
You've probably heard that there are only two really difficult problems in programming: cache invalidation, naming things, and off-by-one errors. Will look through this tomorrow, but in https://github.com/gutenbergtools/pglaf-workflow which is the code that Robert has adapted to carry wikipedia urls, the name of the field is just WIKIPEDIA_URL. So in this code, we don't want to introduce new names. Adding "book_" to "wikipedia_url" seems redundant. The DublinCore object is already about a book. If we introduce other types of wikipedia url it would likely modify something else, like author or subject. |
|
Yeah I added it because we have authror wikipedia urls, a bit semantic but I wanted to distinguish so no one passed author wikipedia URLS via the dispatcher to the section thats for books, I can easily change it you want. |
|
yes, change it |
eshellman
left a comment
eshellman
left a comment
There was a problem hiding this comment.
just reviewed changes in DublinCore
|
Thanks Ill check them out and make the edits. |
2 participants
DublinCoreMapping.pynamedget_wikipedia_urls()andadd_wikipedia_url. The former returns a list of wikipedia urls for a given author, and the latter adds a wikipedia url to a books attributes in the db.