Docker Images Build Issue with -race flag / Problème de construction des images Docker avec le paramètre -race#416
Open
leknoppix wants to merge 12 commits intoh2non:masterfrom
Open
Docker Images Build Issue with -race flag / Problème de construction des images Docker avec le paramètre -race#416leknoppix wants to merge 12 commits intoh2non:masterfrom
leknoppix wants to merge 12 commits intoh2non:masterfrom
Conversation
added 12 commits
September 29, 2023 10:53
- Added SPDX license headers to all source files for compliance. - Updated file permissions for test data and source files to be executable. - Refactored HTTP image source to return headers along with image data. - Improved origin restriction logic with helper functions for clarity. - Updated tests to reflect changes in the HTTP image source and added new test cases. - Replaced deprecated ioutil package with os and io packages for file operations. - Enhanced image type handling in type.go to support additional formats like AVIF.
- Created golangci-lint log file to capture linting results. - Added system log files for lint and test jobs in GitHub Actions. - Updated source_http.go to suppress specific lint warnings related to potential security issues (gosec). - Addressed various linting issues reported by golangci-lint, including error handling and string formatting.
…irective in fetchImage
…quets dans le Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello team,
I am planning to open a pull request for the project. I have set up a CI process to rebuild Docker images for AMD64 and aarch64 (arm64) processors during each push. However, I have encountered an issue with the -race flag used in the Dockerfile.
Specifically, the original instruction:
RUN go test ./... -test.v -race -test.coverprofile=atomic .works fine when replaced with:
RUN go test ./... -test.v -test.coverprofile=atomic .I'll keep researching on ways to maintain the -race flag, but the compilation process is successful in the meantime.
I look forward to your guidance on how to proceed with this matter
Bonjour l'équipe,
Je prévois d'ouvrir une requête pull pour le projet. J'ai créé un processus CI qui reconstruit les images Docker pour les processeurs AMD64 et aarch64 (arm64) à chaque push. Cependant, j'ai rencontré un problème avec le paramètre -race utilisé dans le Dockerfile. Plus précisément, l'instruction originale:
RUN go test ./... -test.v -race -test.coverprofile=atomic .fonctionne correctement lorsqu'il est remplacé par:
RUN go test ./... -test.v -test.coverprofile=atomic .J'irai continuer à chercher des moyens de maintenir le paramètre -race, mais le processus de compilation est succès dans l'attente.
J'ai hâte d'avoir votre guidage sur comment procéder avec cette affaire.
leknoppix