Skip to content

Feature/automated test failure detector #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanxizh9910 merged 3 commits into from
Mar 19, 2026
Merged

Feature/automated test failure detector #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
205589f
Intentional failure for moduleapi tests
hanxizh9910 Mar 19, 2026
4c50aad
Removed two tests that will run more than 1 hour
hanxizh9910 Mar 19, 2026
3c021d1
Added back the dummy intentional failure in valkey test
hanxizh9910 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
212 changes: 106 additions & 106 deletions .github/workflows/daily.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,108 +620,108 @@ jobs:
uses: ./.github/actions/upload-test-failures
with:
job-name: ${{ github.job }}
test-ubuntu-io-threads:
runs-on: ubuntu-latest
if: |
(github.event_name == 'workflow_call' || github.event_name == 'workflow_dispatch' ||
(github.event_name == 'schedule' && github.repository == 'valkey-io/valkey') ||
(github.event_name == 'pull_request' &&
(github.event.pull_request.base.ref != 'unstable' ||
contains(github.event.pull_request.labels.*.name, 'run-extra-tests')) &&
(github.event.action != 'labeled' ||
(github.event.pull_request.base.ref == 'unstable' && github.event.label.name == 'run-extra-tests'))
)) &&
!contains(github.event.inputs.skipjobs, 'iothreads')
timeout-minutes: 1440
steps:
- name: prep
if: github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call'
run: |
echo "GITHUB_REPOSITORY=${{inputs.use_repo || github.event.inputs.use_repo}}" >> $GITHUB_ENV
echo "GITHUB_HEAD_REF=${{inputs.use_git_ref || github.event.inputs.use_git_ref}}" >> $GITHUB_ENV
echo "skipjobs: ${{github.event.inputs.skipjobs}}"
echo "skiptests: ${{github.event.inputs.skiptests}}"
echo "test_args: ${{github.event.inputs.test_args}}"
echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}"
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
repository: ${{ inputs.use_repo || github.event.inputs.use_repo || github.repository }}
ref: ${{ inputs.use_git_ref || github.event.inputs.use_git_ref || github.ref }}
- name: Install libbacktrace
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
repository: ianlancetaylor/libbacktrace
ref: b9e40069c0b47a722286b94eb5231f7f05c08713
path: libbacktrace
- run: cd libbacktrace && ./configure && make && sudo make install
- name: make
run: make SERVER_CFLAGS='-Werror' USE_LIBBACKTRACE=yes
- name: testprep
run: sudo apt-get install tcl8.6 tclx
- name: test
if: true && !contains(github.event.inputs.skiptests, 'valkey')
run: ./runtest --io-threads --accurate --failures-json test-failures/valkey.json --verbose --tags network --dump-logs ${{github.event.inputs.test_args}}
- name: cluster tests
if: true && !contains(github.event.inputs.skiptests, 'cluster')
run: ./runtest-cluster --failures-json test-failures/cluster.json --io-threads ${{github.event.inputs.cluster_test_args}}
- name: Upload test failures
if: always()
uses: ./.github/actions/upload-test-failures
with:
job-name: ${{ github.job }}
test-ubuntu-tls-io-threads:
runs-on: ubuntu-latest
if: |
(github.event_name == 'workflow_call' || github.event_name == 'workflow_dispatch' ||
(github.event_name == 'schedule' && github.repository == 'valkey-io/valkey') ||
(github.event_name == 'pull_request' &&
(github.event.pull_request.base.ref != 'unstable' ||
contains(github.event.pull_request.labels.*.name, 'run-extra-tests')) &&
(github.event.action != 'labeled' ||
(github.event.pull_request.base.ref == 'unstable' && github.event.label.name == 'run-extra-tests'))
)) &&
!contains(github.event.inputs.skipjobs, 'tls') && !contains(github.event.inputs.skipjobs, 'iothreads')
timeout-minutes: 1440
steps:
- name: prep
if: github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call'
run: |
echo "GITHUB_REPOSITORY=${{inputs.use_repo || github.event.inputs.use_repo}}" >> $GITHUB_ENV
echo "GITHUB_HEAD_REF=${{inputs.use_git_ref || github.event.inputs.use_git_ref}}" >> $GITHUB_ENV
echo "skipjobs: ${{github.event.inputs.skipjobs}}"
echo "skiptests: ${{github.event.inputs.skiptests}}"
echo "test_args: ${{github.event.inputs.test_args}}"
echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}"
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
repository: ${{ inputs.use_repo || github.event.inputs.use_repo || github.repository }}
ref: ${{ inputs.use_git_ref || github.event.inputs.use_git_ref || github.ref }}
- name: Install libbacktrace
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
repository: ianlancetaylor/libbacktrace
ref: b9e40069c0b47a722286b94eb5231f7f05c08713
path: libbacktrace
- run: cd libbacktrace && ./configure && make && sudo make install
- name: make
run: make BUILD_TLS=yes SERVER_CFLAGS='-Werror' USE_LIBBACKTRACE=yes
- name: testprep
run: |
sudo apt-get install tcl8.6 tclx tcl-tls
./utils/gen-test-certs.sh
- name: test
if: true && !contains(github.event.inputs.skiptests, 'valkey')
run: |
./runtest --io-threads --tls --accurate --failures-json test-failures/valkey.json --verbose --tags network --dump-logs ${{github.event.inputs.test_args}}
- name: cluster tests
if: true && !contains(github.event.inputs.skiptests, 'cluster')
run: |
./runtest-cluster --failures-json test-failures/cluster.json --io-threads --tls ${{github.event.inputs.cluster_test_args}}
- name: Upload test failures
if: always()
uses: ./.github/actions/upload-test-failures
with:
job-name: ${{ github.job }}
# test-ubuntu-io-threads:
# runs-on: ubuntu-latest
# if: |
# (github.event_name == 'workflow_call' || github.event_name == 'workflow_dispatch' ||
# (github.event_name == 'schedule' && github.repository == 'valkey-io/valkey') ||
# (github.event_name == 'pull_request' &&
# (github.event.pull_request.base.ref != 'unstable' ||
# contains(github.event.pull_request.labels.*.name, 'run-extra-tests')) &&
# (github.event.action != 'labeled' ||
# (github.event.pull_request.base.ref == 'unstable' && github.event.label.name == 'run-extra-tests'))
# )) &&
# !contains(github.event.inputs.skipjobs, 'iothreads')
# timeout-minutes: 1440
# steps:
# - name: prep
# if: github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call'
# run: |
# echo "GITHUB_REPOSITORY=${{inputs.use_repo || github.event.inputs.use_repo}}" >> $GITHUB_ENV
# echo "GITHUB_HEAD_REF=${{inputs.use_git_ref || github.event.inputs.use_git_ref}}" >> $GITHUB_ENV
# echo "skipjobs: ${{github.event.inputs.skipjobs}}"
# echo "skiptests: ${{github.event.inputs.skiptests}}"
# echo "test_args: ${{github.event.inputs.test_args}}"
# echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}"
# - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
# with:
# repository: ${{ inputs.use_repo || github.event.inputs.use_repo || github.repository }}
# ref: ${{ inputs.use_git_ref || github.event.inputs.use_git_ref || github.ref }}
# - name: Install libbacktrace
# uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
# with:
# repository: ianlancetaylor/libbacktrace
# ref: b9e40069c0b47a722286b94eb5231f7f05c08713
# path: libbacktrace
# - run: cd libbacktrace && ./configure && make && sudo make install
# - name: make
# run: make SERVER_CFLAGS='-Werror' USE_LIBBACKTRACE=yes
# - name: testprep
# run: sudo apt-get install tcl8.6 tclx
# - name: test
# if: true && !contains(github.event.inputs.skiptests, 'valkey')
# run: ./runtest --io-threads --accurate --failures-json test-failures/valkey.json --verbose --tags network --dump-logs ${{github.event.inputs.test_args}}
# - name: cluster tests
# if: true && !contains(github.event.inputs.skiptests, 'cluster')
# run: ./runtest-cluster --failures-json test-failures/cluster.json --io-threads ${{github.event.inputs.cluster_test_args}}
# - name: Upload test failures
# if: always()
# uses: ./.github/actions/upload-test-failures
# with:
# job-name: ${{ github.job }}
# test-ubuntu-tls-io-threads:
# runs-on: ubuntu-latest
# if: |
# (github.event_name == 'workflow_call' || github.event_name == 'workflow_dispatch' ||
# (github.event_name == 'schedule' && github.repository == 'valkey-io/valkey') ||
# (github.event_name == 'pull_request' &&
# (github.event.pull_request.base.ref != 'unstable' ||
# contains(github.event.pull_request.labels.*.name, 'run-extra-tests')) &&
# (github.event.action != 'labeled' ||
# (github.event.pull_request.base.ref == 'unstable' && github.event.label.name == 'run-extra-tests'))
# )) &&
# !contains(github.event.inputs.skipjobs, 'tls') && !contains(github.event.inputs.skipjobs, 'iothreads')
# timeout-minutes: 1440
# steps:
# - name: prep
# if: github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call'
# run: |
# echo "GITHUB_REPOSITORY=${{inputs.use_repo || github.event.inputs.use_repo}}" >> $GITHUB_ENV
# echo "GITHUB_HEAD_REF=${{inputs.use_git_ref || github.event.inputs.use_git_ref}}" >> $GITHUB_ENV
# echo "skipjobs: ${{github.event.inputs.skipjobs}}"
# echo "skiptests: ${{github.event.inputs.skiptests}}"
# echo "test_args: ${{github.event.inputs.test_args}}"
# echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}"
# - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
# with:
# repository: ${{ inputs.use_repo || github.event.inputs.use_repo || github.repository }}
# ref: ${{ inputs.use_git_ref || github.event.inputs.use_git_ref || github.ref }}
# - name: Install libbacktrace
# uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
# with:
# repository: ianlancetaylor/libbacktrace
# ref: b9e40069c0b47a722286b94eb5231f7f05c08713
# path: libbacktrace
# - run: cd libbacktrace && ./configure && make && sudo make install
# - name: make
# run: make BUILD_TLS=yes SERVER_CFLAGS='-Werror' USE_LIBBACKTRACE=yes
# - name: testprep
# run: |
# sudo apt-get install tcl8.6 tclx tcl-tls
# ./utils/gen-test-certs.sh
# - name: test
# if: true && !contains(github.event.inputs.skiptests, 'valkey')
# run: |
# ./runtest --io-threads --tls --accurate --failures-json test-failures/valkey.json --verbose --tags network --dump-logs ${{github.event.inputs.test_args}}
# - name: cluster tests
# if: true && !contains(github.event.inputs.skiptests, 'cluster')
# run: |
# ./runtest-cluster --failures-json test-failures/cluster.json --io-threads --tls ${{github.event.inputs.cluster_test_args}}
# - name: Upload test failures
# if: always()
# uses: ./.github/actions/upload-test-failures
# with:
# job-name: ${{ github.job }}
test-ubuntu-reclaim-cache:
runs-on: ubuntu-latest
if: |
Expand Down Expand Up @@ -2080,8 +2080,8 @@ jobs:
- test-ubuntu-32bit
- test-ubuntu-tls
- test-ubuntu-tls-no-tls
- test-ubuntu-io-threads
- test-ubuntu-tls-io-threads
# - test-ubuntu-io-threads
# - test-ubuntu-tls-io-threads
- test-valgrind-test
- test-valgrind-misc
- test-valgrind-no-malloc-usable-size-test
Expand Down Expand Up @@ -2180,8 +2180,8 @@ jobs:
- test-ubuntu-32bit
- test-ubuntu-tls
- test-ubuntu-tls-no-tls
- test-ubuntu-io-threads
- test-ubuntu-tls-io-threads
# - test-ubuntu-io-threads
# - test-ubuntu-tls-io-threads
- test-ubuntu-reclaim-cache
- test-valgrind-test
- test-valgrind-misc
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/moduleapi/auth.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ start_server {tags {"modules"}} {

# Verify returned id is the same as our current id and
# we are authenticated with the specified user
assert_equal [r acl whoami] "global"
assert_equal [r acl whoami] "globall"
}

test {De-authenticating clients is tracked and kills clients} {
Expand Down
Loading