Skip to content

Feature/on edit functionality #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AyushAdh1 merged 5 commits into from
May 13, 2026
Merged

Feature/on edit functionality #54

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2cd86cf
feat(rule-book): implement field rule book history management and sch…
May 12, 2026
1483af6
feat(rule-book): add effective date and version fields to rule books …
May 13, 2026
04344cd
feat(edit-functionality): update EditTimeRange API with dynamic URL a…
May 13, 2026
c23ff4b
feat(migration): remove redundant updates and constraints from field_…
May 13, 2026
d1c9d08
feat(migration): enforce existence checks before adding effective dat…
May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ApiDocs/HelloFutsal/Booking/BulkBookSlots.bru
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ body:json {
"fieldId": "{{fieldId}}",
"startDate": "2026-05-10",
"endDate": "2026-05-12",
"startTime": "6:00",
"endTime": "11:00",
"userName": "John Doe",
"phoneNumber": "+9779800000000"
}
Expand Down
18 changes: 11 additions & 7 deletions ...oFutsal/Rule Book/UpdateFieldRuleBook.bru → .../Rule Book/EditRuleBook/EditTimeRange.bru
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
meta {
name: UpdateFieldRuleBook
name: EditTimeRange
type: http
seq: 8
seq: 1
}

patch {
url: {{development}}/fields/{{fieldId}}/rule-books/{{ruleBookId}}
url: {{development}}/fields/{{fieldId}}/rule-books/{{rulebookId}}
body: json
auth: bearer
}

headers {
Content-Type: application/json
~Authorization: Bearer {{token}}
~Authorization: Bearer YOUR_TOKEN
}

auth:bearer {
Expand All @@ -21,16 +21,20 @@ auth:bearer {

body:json {
{
"effectiveDate": "2026-05-21",
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Avoid hard-coded calendar dates in request examples.

Line 24 uses a fixed date ("2026-05-21"), which will become stale and can mislead API consumers when copied. Prefer a placeholder/example format.

Suggested doc tweak 
-    "effectiveDate": "2026-05-21",
+    "effectiveDate": "YYYY-MM-DD",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"effectiveDate": "2026-05-21",
"effectiveDate": "YYYY-MM-DD",
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ApiDocs/HelloFutsal/Rule` Book/EditRuleBook/EditTimeRange.bru at line 24,
Replace the hard-coded calendar date used in the request example for the
"effectiveDate" field (currently "2026-05-21") with a placeholder or example
format (e.g., "YYYY-MM-DD" or "{effectiveDate}") so consumers don't copy stale
values; update the EditTimeRange example where "effectiveDate" is defined to use
the placeholder and, if desired, add a brief note about the expected ISO date
format.

"ruleName": "Early Bird Morning Special",
"slotSelectionType": "timeRange",
"actionType": "fixedPrice",
"value": 1000,
"value": 10,
"activeDays": [
"sunday"
"monday",
"wednesday",
"friday"
],
"timeRange": {
"startTime": "06:00",
"endTime": "11:00"
}
},
"isActive": true
}
}
30 changes: 0 additions & 30 deletions ApiDocs/HelloFutsal/Rule Book/UpdateFieldRuleBookAllSlots.bru
View file
Open in desktop

This file was deleted.

40 changes: 0 additions & 40 deletions ApiDocs/HelloFutsal/Rule Book/UpdateFieldRuleBookSpecificSlots.bru
View file
Open in desktop

This file was deleted.

34 changes: 0 additions & 34 deletions ApiDocs/HelloFutsal/Rule Book/UpdateFieldRuleBookTimeRange.bru
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions ApiDocs/HelloFutsal/VerifyOTP/Admin OTP Verify.bru
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ auth:bearer {

body:json {
{
"requestId": "dcec5e4b-303c-4fd2-ac10-204f6e872c04",
"otp": "160433"
"requestId": "57864a07-ec0d-493d-a474-0dc0548ecc39",
"otp": "503657"
}
}
5 changes: 3 additions & 2 deletions ApiDocs/HelloFutsal/environments/Dev.bru
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
vars {
development: http://localhost:3000
fieldId: 1bdfdb6b-41d8-4e39-a38c-398bdca0ba39
token: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIzMDIyMWFkOS0zZjgyLTQzZDgtYjQ1OS1kZGYyMGY2YzgzOTAiLCJlbWFpbCI6bnVsbCwibW9iaWxlTnVtYmVyIjoiOTg2Nzc1NDczOCIsInJvbGUiOiJhZG1pbiIsImlhdCI6MTc3ODMwMDMyOSwiZXhwIjoxNzc4Mzg2NzI5fQ.GHeUq7DIOmimuj6eBVFtFq6HiFXf9oSQP8RS0pW1sCU
fieldId: 7e64459c-4a92-490c-bfdd-4ab660a626e9
token: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIzZjljZWYwZi0zZGQ0LTQwOGMtYTI2Ni0wMDJjN2E3MjlhODUiLCJlbWFpbCI6bnVsbCwibW9iaWxlTnVtYmVyIjoiOTg2Nzc1NDczOCIsInJvbGUiOiJhZG1pbiIsImlhdCI6MTc3ODYzNzYxNywiZXhwIjoxNzc4NzI0MDE3fQ.lF51reUEi07ST1GxobnaRq_nQ9vHWKrmRwRx9yryfYU
ruleBookSpecificSlotId: 2e78fc78-08e4-423e-a8ef-5ff10c59f1a7
ruleBookAllSlotId: 81e212b2-dd86-47db-bb96-8a163b615d61
ruleBookTimeSlotId: 4aebf2ac-9651-4450-8968-812cd487261e
slotId: c7b13c7d-6d73-4e24-941e-d74a8eb18d5f
bookingId: c04ce07f-f1af-4ac2-a854-2f4394b2c565
scheduleSettingId: c06a9396-8f7f-4158-94d9-59ebd9d0adfd
membershipId: 528852ea-9aa7-499f-bb9d-77301c0f8eae
rulebookId: 5d6ca08c-cfad-4273-9656-66b4cdb13262
}
Loading
Loading