Skip to content

Feature/on edit functionality #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AyushAdh1 merged 5 commits into from
May 13, 2026
Merged

Feature/on edit functionality #54

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2cd86cf
feat(rule-book): implement field rule book history management and sch…
May 12, 2026
1483af6
feat(rule-book): add effective date and version fields to rule books …
May 13, 2026
04344cd
feat(edit-functionality): update EditTimeRange API with dynamic URL a…
May 13, 2026
c23ff4b
feat(migration): remove redundant updates and constraints from field_…
May 13, 2026
d1c9d08
feat(migration): enforce existence checks before adding effective dat…
May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ApiDocs/HelloFutsal/Booking/BulkBookSlots.bru
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ body:json {
"fieldId": "{{fieldId}}",
"startDate": "2026-05-10",
"endDate": "2026-05-12",
"startTime": "6:00",
"endTime": "11:00",
"userName": "John Doe",
"phoneNumber": "+9779800000000"
}
Expand Down
22 changes: 11 additions & 11 deletions ...oFutsal/Rule Book/UpdateFieldRuleBook.bru → .../Rule Book/EditRuleBook/EditTimeRange.bru
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,36 +1,36 @@
meta {
name: UpdateFieldRuleBook
name: EditTimeRange
type: http
seq: 8
seq: 1
}

patch {
url: {{development}}/fields/{{fieldId}}/rule-books/{{ruleBookId}}
url: http://localhost:3000/fields/FIELD_ID/rule-books/RULE_BOOK_ID
body: json
auth: bearer
auth: none
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
}

headers {
Authorization: Bearer YOUR_TOKEN
Content-Type: application/json
~Authorization: Bearer {{token}}
}

auth:bearer {
token: {{token}}
}

body:json {
{
"effectiveDate": "2026-06-01",
"ruleName": "Early Bird Morning Special",
"slotSelectionType": "timeRange",
"actionType": "fixedPrice",
"value": 1000,
"activeDays": [
"sunday"
"monday",
"wednesday",
"friday"
],
"timeRange": {
"startTime": "06:00",
"endTime": "11:00"
}
},
"isActive": true
}
}
30 changes: 0 additions & 30 deletions ApiDocs/HelloFutsal/Rule Book/UpdateFieldRuleBookAllSlots.bru
View file
Open in desktop

This file was deleted.

40 changes: 0 additions & 40 deletions ApiDocs/HelloFutsal/Rule Book/UpdateFieldRuleBookSpecificSlots.bru
View file
Open in desktop

This file was deleted.

34 changes: 0 additions & 34 deletions ApiDocs/HelloFutsal/Rule Book/UpdateFieldRuleBookTimeRange.bru
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions ApiDocs/HelloFutsal/VerifyOTP/Admin OTP Verify.bru
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ auth:bearer {

body:json {
{
"requestId": "dcec5e4b-303c-4fd2-ac10-204f6e872c04",
"otp": "160433"
"requestId": "57864a07-ec0d-493d-a474-0dc0548ecc39",
"otp": "503657"
}
}
4 changes: 2 additions & 2 deletions ApiDocs/HelloFutsal/environments/Dev.bru
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
vars {
development: http://localhost:3000
fieldId: 1bdfdb6b-41d8-4e39-a38c-398bdca0ba39
token: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIzMDIyMWFkOS0zZjgyLTQzZDgtYjQ1OS1kZGYyMGY2YzgzOTAiLCJlbWFpbCI6bnVsbCwibW9iaWxlTnVtYmVyIjoiOTg2Nzc1NDczOCIsInJvbGUiOiJhZG1pbiIsImlhdCI6MTc3ODMwMDMyOSwiZXhwIjoxNzc4Mzg2NzI5fQ.GHeUq7DIOmimuj6eBVFtFq6HiFXf9oSQP8RS0pW1sCU
fieldId: 80607ec4-9caf-4e38-a7d2-337e5c2343bb
token: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxNzQ5MWQxMy1hMGEwLTRlNjctYTg1OC0yN2FlYWZmYTQxMTgiLCJlbWFpbCI6bnVsbCwibW9iaWxlTnVtYmVyIjoiOTg2Nzc1NDczOCIsInJvbGUiOiJhZG1pbiIsImlhdCI6MTc3ODQyNDYxOCwiZXhwIjoxNzc4NTExMDE4fQ.dhztQY8hLUCCXt_MRx4TcCp9O_7SBuw6tZqJONjVLis
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Remove committed bearer token and rotate it immediately.

Line 4 contains a real credential in source control. This is a secret/PII exposure risk (and potentially privileged access). Revoke/rotate the token now, and keep only a placeholder in tracked env files while storing the real value in an untracked local secret source.

Suggested tracked-file change 
-  token: <hardcoded-jwt>
+  token: __SET_LOCALLY_DO_NOT_COMMIT__
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ApiDocs/HelloFutsal/environments/Dev.bru` at line 4, The Dev.bru environment
file contains a committed bearer value under the token key; remove the actual
token string, revoke/rotate it immediately, replace it in Dev.bru with a
non-sensitive placeholder (e.g. token: <REDACTED> or TOKEN_PLACEHOLDER), and
ensure the real secret is moved to an untracked secret store (local env vars,
.env.local added to .gitignore, or a secrets manager) before committing; commit
the placeholder change and document how to inject the real token for local/dev
use.

ruleBookSpecificSlotId: 2e78fc78-08e4-423e-a8ef-5ff10c59f1a7
ruleBookAllSlotId: 81e212b2-dd86-47db-bb96-8a163b615d61
ruleBookTimeSlotId: 4aebf2ac-9651-4450-8968-812cd487261e
Expand Down
Loading
Loading