fix(ci): P0 PR hygiene — block low-quality submissions#36
Merged
Conversation
Harden contribution quality before human review: expand validate.py with HTTPS/no-tracking URLs, duplicate detection, notes limits, and status honesty rules; add README table --check-pr so hand-edits fail CI; fix RouteScope (#25) into providers.yaml without affiliate params.
Give coding agents a single decision tree and hard CI rules so submissions stop hand-editing READMEs / pasting marketing copy. Maintainer close template points resubmitters at the same playbook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the P0 contribution-quality gates:
scripts/validate.py: HTTPS-only URLs; rejectutm_*/ referral query params; duplicate name/URL; notes ≤360 chars + marketing ban phrases;status: activerequires maintainer verify;operator_submittedcannot beactive.scripts/build_provider_tables.py:--check(full drift) and--check-pr(block hand-edited README tables; allow yaml-only PRs).pr-validate.yml): also runs on README paths; full history +PR_BASE_SHAfor the PR check.data/providers.yamlasunverified+operator_submitted, plain HTTPS (no tracking URL); READMEs regenerated.CONTRIBUTING.md, PR template,data/schema.md.Branch protection on
mainalready requires thevalidatestatus check.Test plan
python -m scripts.validateexits 0python -m scripts.build_provider_tables --checkexits 0validateunder branch protection