Skip to content

renderer: cache workspace fullscreen windows#14923

Open
NotPppp1116 wants to merge 2 commits into
hyprwm:mainfrom
NotPppp1116:perf/workspace-fullscreen-cache
Open

renderer: cache workspace fullscreen windows#14923
NotPppp1116 wants to merge 2 commits into
hyprwm:mainfrom
NotPppp1116:perf/workspace-fullscreen-cache

Conversation

@NotPppp1116

@NotPppp1116 NotPppp1116 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

cache each workspace's fullscreen window as a weak reference and keep it synchronized across fullscreen transitions, workspace moves, unmaps, and recovery paths
make fullscreen window lookup O(1) while preserving layout-managed fullscreen handling
simplify the fullscreen renderer path: avoid temporary smart-pointer vectors, use the cached fullscreen window in the common path, and keep the broader scan only while other workspaces animate avoid smart-pointer copies across hot renderer helpers and blur predicates by passing handles as const&
cache repeated monitor workspace IDs locally in shouldRenderWindow

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

Hello and thank you for making a PR to Hyprland!

Please check the PR Guidelines and make sure your PR follows them.
It will make the entire review process faster. :)

If your code can be tested, please always add tests. See more here.

beep boop, I'm just a bot. A real human will review your PR soon.

@NotPppp1116 NotPppp1116 force-pushed the perf/workspace-fullscreen-cache branch from 778b9ed to 13a05ba Compare June 1, 2026 16:24
@NotPppp1116 NotPppp1116 marked this pull request as ready for review June 1, 2026 16:35
@vaxerski

vaxerski commented Jun 3, 2026

Copy link
Copy Markdown
Member

@codex review please

@vaxerski

vaxerski commented Jun 3, 2026

Copy link
Copy Markdown
Member

this is iffy fullscreen state is quite flaky I dont like it in general but ugh

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13a05ba1f1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/desktop/Workspace.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants