Handle color state for direct scanout#15229
Open
NotPppp1116 wants to merge 3 commits into
Open
Conversation
Contributor
|
DS SDR luminance differences are negligible unless DS is toggled back and forth. At least keep a way to ignore this diff with a config setting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #9064.
This updates direct scanout so fullscreen color state is applied before attempting scanout, and so the output state is rolled back if scanout cannot be committed. When the scanout buffer is unchanged but the color state changed, the direct scanout path now commits the same buffer update instead of presenting feedback without applying the new output state.
It also blocks SDR direct scanout when luminance conversion would be required. CTM can cover compatible primaries, but direct scanout bypasses shader luminance conversion, so luminance mismatches need to fall back to the composited path.
User impact
Validation
cmake --fresh -S . -B buildcmake --build ./build --target Hyprland -j2git diff --checkNote: the fresh CMake configure was needed because the local build cache still referenced an older Abseil library name (
absl_borrowed_fixup_buffer) after the system packages had already moved on.