presentation: associate feedback with committed surface state#15243
Open
NotPppp1116 wants to merge 2 commits into
Open
presentation: associate feedback with committed surface state#15243NotPppp1116 wants to merge 2 commits into
NotPppp1116 wants to merge 2 commits into
Conversation
vaxerski
reviewed
Jun 27, 2026
Contributor
|
@NotPppp1116 should this be merged or the other one be merged? |
Contributor
Author
merge this one |
Contributor
|
okay, btw do u still have discord or did u fully delete everything |
vaxerski
reviewed
Jul 1, 2026
| std::vector<SP<CWLCallbackResource>> callbacks; | ||
|
|
||
| // for wp_presentation feedbacks, tied to this commit. | ||
| std::vector<CPresentationFeedback*> presentationFeedbacks; |
Contributor
Author
I have,u can dm IVE been cleaning up and leaving a lot of servers etc |
Contributor
iirc I got blocked by u after u sent that file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tie wp_presentation feedback objects to committed surface state instead of only to the surface. The change also discards feedback for superseded commits, rejected/queued state cleanup, surface destroy, and monitor removal.
Why
When multiple commits are coalesced or destroyed before presentation, feedback from older or discarded state can otherwise be reported as presented or remain pending.
Validation
git diff --check upstream/main..pr/presentation-feedback-committed-statecmake --build build --target Hyprland -j$(nproc)build/hyprtester/hyprtester -c hyprtester/test.lua -b ./build/Hyprland -p hyprtester/plugin/hyprtestplugin.so fullscreenScanoutStressTransitionspassed when run with the dependent stress-test branch and damage fix applied.Dependency
Independent production fix, but the separate fullscreen scanout stress-test PR is expected to exercise and protect this behavior.