IBX-11909: new main menu design#1944
Conversation
|
|
||
| for (const tooltipNode of tooltipsNode) { | ||
| bootstrap.Tooltip.getOrCreateInstance(tooltipNode).hide(); | ||
| const tooltipInstance = bootstrap.Tooltip.getInstance(tooltipNode); |
There was a problem hiding this comment.
Note: fix needed to avoid creating tooltip instances when hiding tooltips, which circumvent our parse function's custom logic.
|
ibexa-workflow-automation-1
Bot
requested review from
GrabowskiM,
OstafinL,
albozek,
alekmick and
dew326
and removed request for
a team
| padding: 1px 0; | ||
| margin-left: 12px; | ||
| margin-top: 8px; |
There was a problem hiding this comment.
| padding: 1px 0; | |
| margin-left: 12px; | |
| margin-top: 8px; | |
| padding: calculateRem(1px) 0; | |
| margin-left: calculateRem(12px); | |
| margin-top: calculateRem(8px); |
| {% set text_column_class = text_column_class|default('') %} | ||
| {% set text_column_classes = ['ibexa-main-menu__item-text-column', text_column_class]|filter(class => class is not empty) %} |
There was a problem hiding this comment.
If we're in 6.0 where we have twig/html-extra enabled, we can do it like this
{% set text_column_class = html_classes('ibexa-main-menu__item-text-column', text_column_class|default('')) %}
(and latej in line 10 that join is not needed)
html_classes manages itself empty strings and doesn't add unnecessary whitespaces :)
There was a problem hiding this comment.
I followed the old syntax to stay consistent with how it is done in other menu related places :)
| (new Message(self::ITEM_CONTENT__CONTENT_STRUCTURE, 'ibexa_menu'))->setDesc('Content structure'), | ||
| (new Message(self::ITEM_CONTENT__MEDIA, 'ibexa_menu'))->setDesc('Media'), | ||
| (new Message(self::ITEM_ADMIN, 'ibexa_menu'))->setDesc('Admin'), | ||
| (new Message(self::ITEM_ADMIN, 'ibexa_menu'))->setDesc('Administration'), |
There was a problem hiding this comment.
Translation extraction :)
There was a problem hiding this comment.
I'm fixing translations on the base branch and cannot regenerate it until it is fixed :)
6 participants
Description:
For QA:
Documentation: