Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public function getTypeName()
*
* If Selection is improved to be able to index + search for string also with LegacySearch, then adapt this too.
*/
protected function supportsLikeWildcard($value)
protected function supportsLikeWildcard($value): bool
{
return false;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public function testNormalization(): void
$matcher = new HostElement(2);
// Set request and invoke match to initialize HostElement::$hostElements
$matcher->setRequest(SimplifiedRequest::fromUrl('https://ibexa.dev/foo/bar'));
$matcher->match();
self::assertSame('dev', $matcher->match());

self::assertEquals(
self::DATA,
Expand Down
3 changes: 2 additions & 1 deletion tests/lib/Repository/Service/Mock/UrlAliasTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,14 @@
{
$repositoryMock = $this->getRepositoryMock();

$service = new UrlALiasService(
/** @phpstan-ignore new.resultUnused */
new UrlALiasService(
$repositoryMock,
$this->urlAliasHandler,
$this->getNameSchemaServiceMock(),
$this->permissionResolver,
$this->getLanguageResolverMock()
);

Check warning on line 66 in tests/lib/Repository/Service/Mock/UrlAliasTest.php

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Either remove this useless object instantiation of class "UrlALiasService" or use it

See more on https://sonarcloud.io/project/issues?id=ibexa_core&issues=AZ77qDstoahQMtMvAGo2&open=AZ77qDstoahQMtMvAGo2&pullRequest=768
}

/**
Expand Down
Loading