Add implement-from-spec skill for architecture-aware feature work#1043
Open
prashantbytesyntax wants to merge 2 commits into
Open
Add implement-from-spec skill for architecture-aware feature work#1043prashantbytesyntax wants to merge 2 commits into
prashantbytesyntax wants to merge 2 commits into
Conversation
Teach the agent how to turn a design spec into a minimal gProfiler change by mapping it onto the current architecture, choosing the smallest existing flow to extend, and validating the result locally. The skill adds concrete guidance for command-control changes, repo-native test bootstrap, targeted-vs-broad test selection, and regression-aware review before handoff. Co-authored-by: Cursor <cursoragent@cursor.com>
Bring the draft skills closer to the current gProfiler codebase by teaching the dynamic profiling architecture, fixing stale heartbeat references and required flags, adding architecture-aware code review checks, and documenting a staged local test strategy that reuses the repo's existing harness before broader regression runs. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
@prashantbytesyntax, looks good to me. If you want, go ahead combine it with my PR. Or, I can do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This stacks on top of #1042 by adding a new
.claudeskill focused on the end-to-end workflow we want AI agents to follow when implementing gProfiler changes from a design spec.The new
implement-from-specskill teaches the agent to:heartbeat.py,command_control.py,continuous.py,ad_hoc.py) as the default seam for command-driven changes./tests/test.sh,./scripts/copy_resources_from_image.sh) instead of inventing custom setupmain.py,tests/conftest.py, and queue-priority semanticsWhy a new skill
The draft skills in #1042 already cover architecture, testing, review, and heartbeat individually, but they do not yet give an agent one clear workflow for:
This skill fills that gap without making the existing draft skills much longer.
Test plan
SKILL.mdis 155 lines)CONTRIBUTING.mdandtests/test.shMade with Cursor