Skip to content

Fix hash mode to preserve URL pathname #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbuckner wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix hash mode to preserve URL pathname #1521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/plugins/url/UrlPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,9 @@ export class UrlPlugin {
}

if (this.urlMode == 'hash') {
window.location.replace('#' + concatenatedPath);
// Use location.hash instead of location.replace('#...') to preserve
// the current pathname in SPA contexts.
window.location.hash = concatenatedPath;
}
this.oldLocationHash = urlStrPath;
}
Expand Down
5 changes: 4 additions & 1 deletion src/plugins/url/plugin.url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,10 @@ BookReader.prototype.urlUpdateFragment = function() {
} else if (this.textFragmentPage && extractedPage != this.textFragmentPage) {
textFragment = '';
}
window.location.replace('#' + newFragment + newQueryStringSearch + textFragment);
// Use location.hash instead of location.replace('#...') to preserve
// the current pathname. location.replace('#foo') is a relative URL
// that can wipe the path in SPA contexts.
window.location.hash = newFragment + newQueryStringSearch + textFragment;
this.oldLocationHash = newFragment + newQueryStringSearch + textFragment;
}
};
Expand Down
Loading