Highlight quotes and store in browser#1538
Open
schu96 wants to merge 6 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1538 +/- ##
==========================================
- Coverage 68.98% 65.07% -3.92%
==========================================
Files 65 65
Lines 5556 5815 +259
Branches 1229 1291 +62
==========================================
- Hits 3833 3784 -49
- Misses 1689 1989 +300
- Partials 34 42 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cdrini
reviewed
May 6, 2026
| * @param {string} urlString | ||
| * @returns {object} | ||
| */ | ||
| convertParamToHighlight(urlString) { |
Contributor
There was a problem hiding this comment.
This would be better as a single url parameter, similar to our TextFragment from before. Eg ?text=5:prefix,quote,suffix . Note the tweak that includes the page index at the front to help with disambiguation.
|
|
||
| /** The experiments that should be shown in the experiments panel */ | ||
| enabledExperiments: ['translate', 'copyLinkToHighlight'], | ||
| enabledExperiments: ['translate', 'copyLinkToHighlight', 'annotateHighlight'], |
Contributor
There was a problem hiding this comment.
Suggested change
| enabledExperiments: ['translate', 'copyLinkToHighlight', 'annotateHighlight'], | |
| enabledExperiments: ['translate', 'copyLinkToHighlight'], |
Fix for failed test Jest test case fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pivoting from using native browser Text Fragments
Highlights in the bookreader can now be stored in browser localStorage, with plans for annotations coming soon