WIP: Add static default routes when originating BGP default routes#3527
Draft
ipspace wants to merge 1 commit into
Draft
WIP: Add static default routes when originating BGP default routes#3527ipspace wants to merge 1 commit into
ipspace wants to merge 1 commit into
Conversation
Some devices (Junos, BIRD) need a default route in the routing table to originate a BGP default route. To simplify the configuration templates, the bgp.session plugin adds the necessary static routes and activates the 'routing' module on the affected node(s). Working: * Global and VRF static routes are added * Deduplication of added static routes Still missing: * Dual-stack/IPv6 checks * Using existing defaults
jbemmel
reviewed
Jun 26, 2026
| continue | ||
|
|
||
| append_to_list(ndata,'module','routing') # Activate the routing module in the node | ||
| append_to_list(topology,'module','routing') # ... assuming the developer setting BGP features was sane ;) |
Collaborator
There was a problem hiding this comment.
Hope this doesn't activate the routing module on all nodes in the topology?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some devices (Junos, BIRD) need a default route in the routing table to originate a BGP default route. To simplify the configuration templates, the bgp.session plugin adds the necessary static routes and activates the 'routing' module on the affected node(s).
Working:
Still missing: