Fix inaccurate segment GAID validation pattern#79
Open
mattpolicastro wants to merge 2 commits intojdeboer:devfrom
Open
Fix inaccurate segment GAID validation pattern#79mattpolicastro wants to merge 2 commits intojdeboer:devfrom
mattpolicastro wants to merge 2 commits intojdeboer:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Segments created in the native Google Analytics segment builder are automatically assigned GAIDs; these GAIDs are usually alphanumeric but I've noticed that underscores and dashes are beginning to be used as valid characters. However, these IDs will trigger a hard error:
I've amended the regex pattern used to validate the GAIDs to not fail on dashes or underscores.