Use URLClassLoader by default#6571
Merged
basil merged 1 commit intojenkinsci:masterfrom May 15, 2022
basil:AntClassLoader
Merged
Use URLClassLoader by default#6571basil merged 1 commit intojenkinsci:masterfrom basil:AntClassLoader
URLClassLoader by default#6571basil merged 1 commit intojenkinsci:masterfrom
basil:AntClassLoader
Conversation
timja
approved these changes
May 14, 2022
NotMyFault
approved these changes
May 14, 2022
Member
Author
|
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #5698 we have supported both
URLClassLoaderandAntClassLoader, withAntClassLoaderas the default. The main reason to useAntClassLoaderwas the Bouncy Castle API plugin, but recent versions (including the version bundled in Jenkins core) have supportedURLClassLoaderfor a while now. In addition, as of #5865AntClassLoaderhad to be marked as not parallel capable, whileURLClassLoaderhas never had such a restriction. Since it is the beginning of a new LTS cycle, I think it makes sense to switch the default toURLClassLoader, which also enables parallel class loading.Proposed changelog entries
Use native Java Platform functionality rather than Ant to load classes. The old behavior can be restored by setting
-Dhudson.ClassicPluginStrategy.useAntClassLoader=true.Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entriessection only if there are breaking changes or other changes which may require extra steps from users during the upgrade@Restrictedor have@since TODOJavadoc, as appropriate.Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge:Proposed changelog entriesare accurate, human-readable, and in the imperative moodupgrade-guide-neededlabel is set and there is aProposed upgrade guidelinessection in the PR title. (example)lts-candidateto be considered (see query).