Fix Go module path separators in remediation commands#1348
Open
omribz156 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Normalize Go module names reported with colon separators before building the
go getremediation command.Keep the normalization scoped to Go package updates so Maven-style coordinates are not affected.
Add coverage for slash-separated and colon-separated Go module paths.
All tests passed. If this feature is not already covered by the tests, I added new tests.
This pull request is on the dev branch.
I used gofmt for formatting the code before submitting the pull request.
Update documentation about new features / new supported technologies
Verification:
gofmt -w packagehandlers\gopackagehandler.go packagehandlers\packagehandlers_test.gogo test ./packagehandlers -run TestNormalizeGoModulePath -count=1go test ./packagehandlers -run "TestNormalizeGoModulePath|TestUpdateDependency" -count=1was also tried, butTestUpdateDependencyrequiresJF_URLin this local environment.Docs note: this is a bug fix for existing Go remediation behavior, not a new feature or new supported technology.
This was implemented with Codex assistance, with the final diff manually reviewed and kept focused on issue #1243.