Stack height classifier#1
Open
hkwon214 wants to merge 15 commits intograsp_pytorch0.4+from
Open
Conversation
…r_visual_stacking into grasp_pytorch0.4+
…+' into grasp_pytorch0.4+
ahundt
requested changes
Aug 30, 2019
Member
ahundt
left a comment
ahundt
left a comment
There was a problem hiding this comment.
Aside from the logger this mostly seems fine for now. Can you explain the second logger file?
| import csv | ||
| # import h5py | ||
|
|
||
| class Logger(): |
Member
There was a problem hiding this comment.
Why is a whole copied (and modified?) Logger class needed for the classifier? This does not seem like the right way to implement this.
Is there a way the existing logger can be used, perhaps with minor modifications?
Collaborator
Author
There was a problem hiding this comment.
i created another logger.py thinking it won't be part of the existing branch.
But yes, it is better to use the existing logger with some changes.
Collaborator
Author
There was a problem hiding this comment.
I deleted the second logger file and used the existing logger.py file
Member
|
Hey any updates on the classifier component? |
ahundt
added a commit
that referenced
this pull request
Jun 27, 2020
add primesense code source links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack height classifier data generating script