[x2cpg] Possible replacement implementation for findSupportedBuildFiles.#5959
Open
ml86 wants to merge 1 commit into
Open
[x2cpg] Possible replacement implementation for findSupportedBuildFiles.#5959ml86 wants to merge 1 commit into
ml86 wants to merge 1 commit into
Conversation
This implementation does not do its own recursion and does not just take the first ".gradle" file in each subdirectory. Question is: Was that done on purpose? I highly doubt it but will wait until futher clarification.
ml86
changed the title
Contributor
|
I guess we should make use of https://github.com/joernio/joern/blob/master/joern-cli/frontends/x2cpg/src/main/scala/io/joern/x2cpg/SourceFiles.scala here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation does not do its own recursion and does not just take
the first ".gradle" file in each subdirectory.
Question is: Was that done on purpose? I highly doubt it but will wait
until futher clarification.
@johannescoetzee Please come back to me on this one to discuss.