[New Feature]: Suggestions#15
Open
sricharankrishnan wants to merge 1 commit intojonschlinkert:masterfrom
sricharankrishnan:sricharankrishnan-contrib
Open
[New Feature]: Suggestions#15sricharankrishnan wants to merge 1 commit intojonschlinkert:masterfrom sricharankrishnan:sricharankrishnan-contrib
sricharankrishnan wants to merge 1 commit intojonschlinkert:masterfrom
sricharankrishnan:sricharankrishnan-contrib
Conversation
sricharankrishnan
commented
Jan 4, 2022
sricharankrishnan
commented
- introduced 'Check Is Array' in the module.exports section to make sure that we receive an array
- using pre built 'Array.forEach' to iterate over the first array
- using pre build 'Array.findIndex' to fetch the index for the item to be check for in the diff array
- introduced 'Check Is Array' in the module.exports section to make sure that we receive an array - using pre built 'Array.forEach' to iterate over the first array - using pre build 'Array.findIndex' to fetch the index for the item to be check for in the diff array
Author
|
Hello Jon. Here is another suggestion from my side on how this could be redone. Let me know your thoughts on this. |
I don't think this is worth it because whatever code is calling arr-diff should make sure to input arrays. This would slightly slow down performance when it is used correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.