Skip to content

Fix for review suggestions https://github.com/ome/omero-py/pull/199#15

Merged
joshmoore merged 1 commit into
joshmoore:default-groupfrom
Tom-TBT:default-group
Mar 25, 2026
Merged

Fix for review suggestions https://github.com/ome/omero-py/pull/199#15
joshmoore merged 1 commit into
joshmoore:default-groupfrom
Tom-TBT:default-group

Conversation

@Tom-TBT

@Tom-TBT Tom-TBT commented Feb 3, 2026

Copy link
Copy Markdown
  • checks that a single group is provided before filtering groups on pre-existing group membership
  • sets group as default even if the user was already part of the group
  • extended --as-default option description to reflect these changes

Copilot AI review requested due to automatic review settings February 3, 2026 14:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request addresses review feedback from PR ome#199 by improving the joingroup command's handling of the --as-default flag. The main change ensures that a group can be set as the default group even if the user is already a member of that group.

Changes:

  • Validates that only a single group is provided before filtering for group membership
  • Stores the target group before filtering so it can be set as default even if already a member
  • Updates help text to clarify the --as-default behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/omero/plugins/user.py

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@joshmoore joshmoore merged commit b6baea3 into joshmoore:default-group Mar 25, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants