Fix for review suggestions https://github.com/ome/omero-py/pull/199#15
Merged
Merged
Conversation
Tom-TBT
commented
Feb 3, 2026
- checks that a single group is provided before filtering groups on pre-existing group membership
- sets group as default even if the user was already part of the group
- extended --as-default option description to reflect these changes
…ys sets it as new default group
There was a problem hiding this comment.
Pull request overview
This pull request addresses review feedback from PR ome#199 by improving the joingroup command's handling of the --as-default flag. The main change ensures that a group can be set as the default group even if the user is already a member of that group.
Changes:
- Validates that only a single group is provided before filtering for group membership
- Stores the target group before filtering so it can be set as default even if already a member
- Updates help text to clarify the
--as-defaultbehavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.