Skip to content

Update package.json #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
L-Qun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update package.json #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@
"webpack": "^5.93.0"
},
"peerDependencies": {
"react": ">=17.0.0"
"react": ">=18.0.0"
Copy link
Copy Markdown
Member

@arjunvegda arjunvegda Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I think we want to be react 17 friendly for a short while.

Could you help us identify the hooks that rely on useId and help write a custom impl. that lives within our repo? (@Elvincth is helping us migrate away from @mantine/* so hopefully this shouldn't be a huge issue)

Copy link
Copy Markdown
Author

@L-Qun L-Qun Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a simpler approach would be to downgrade the version of @mantine/* to meet the requirements of react>=17. What do you think?

Copy link
Copy Markdown
Member

@arjunvegda arjunvegda Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, that is not an option, it'd require a lot more changes. Mantine v6 -> v7 was a breaking change. 😟

},
"dependencies": {
"@mantine/code-highlight": "^7.11.2",
Expand Down